Remove dead headers#1427
Merged
Merged
Conversation
Remove the dead netinet6/in6.h imports from ODWReachability and its Objective-C unit test so Apple builds no longer fail on the private-header error from main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ThomsonTan
reviewed
Apr 21, 2026
| #import <XCTest/XCTest.h> | ||
| #import "ODWReachability.h" | ||
|
|
||
| #import <sys/socket.h> |
Contributor
There was a problem hiding this comment.
The netinet6/in6.h removal fixes #1418, but this file still uses struct sockaddr_in, AF_INET, IN_LINKLOCALNETNUM, and htonl, whose canonical headers are /.
Contributor
Author
There was a problem hiding this comment.
I was relying on headers being brought transitively (arpa/inet.h brings in netinet/in.h and ODWReachability.h brings in SystemConfiguration, which brings in sys/socket.h), so had removed the headers, but I am now reverting that changes to keep the canonical header files where these are defined explicit. I will now only use this PR to remove dead headers.
ThomsonTan
reviewed
Apr 21, 2026
Add back the canonical sys/socket.h and netinet/in.h includes in ODWReachability.m and ODWReachabilityTests.mm while keeping the other dead imports removed. This avoids relying on transitive Apple headers in the reachability PR review. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bmehta001
force-pushed
the
bhamehta/issue-1418-main
branch
from
0f96478 to
7726379
Compare
ThomsonTan
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1418